Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): switch to upstream action and update workflows #1034

Merged
merged 24 commits into from
Mar 28, 2024
Merged

chore(ci): switch to upstream action and update workflows #1034

merged 24 commits into from
Mar 28, 2024

Conversation

noelmiller
Copy link
Member

@noelmiller noelmiller commented Mar 19, 2024 •
edited
Loading

BLOCKERS:

  • Change @main to @version_number when action is published
  • All images need to successfully build
  • BEFORE MERGING, readd surface images to build.
  • THIS NEEDS TO MERGE BEFORE MERGING: fix: remove old yafti #1051 (review)

@noelmiller noelmiller changed the title chore(ci): switch to upstream action and combine workflows chore(ci): switch to upstream action and update workflows Mar 20, 2024
@abanna
Copy link

abanna commented Mar 27, 2024

not required but useful

RUN <<EOF
echo "Hello" >> /hello
echo "World!" >> /hello
EOF

noelmiller and others added 16 commits March 27, 2024 11:54
@noelmiller
chore(ci): disable surface temporarily
9b095e0
@noelmiller
chore(ci): switch to release
9969d2f
@noelmiller
chore(ci): rename ublue-system-flatpak-manager.service and update con…
00c885c 
…tainer file
@noelmiller
chore(ci): remove --global and debug ref_name
be97a24
@noelmiller
chore(ci): fixup capitalization and fixup tag
cdb4fd2
@noelmiller
chore(ci): cleaned up formatting and using version 1.1.1
4962cee
@noelmiller
chore(ci): Add as user service instead
5f7d2d0
@noelmiller
chore(ci): fixup ublue-flatpak-manager to only run once
4c27dc2
@noelmiller
chore(ci): changed WantedBy to default.target
a8cd7c0
@noelmiller
Merge branch 'main' into testing
8eefca0
@noelmiller
chore(ci): fixup merge conflict
42ece0b
@noelmiller
chore(ci): add surface back
1dbd2c4
@noelmiller
Merge branch 'main' into testing
8422691
@noelmiller
chore(ci): add framework back
16014cc
@noelmiller
chore(ci): move include back up
00f44fc
@noelmiller
chore(ci): remove debug statement
536829e
@noelmiller noelmiller marked this pull request as ready for review March 28, 2024 15:55
@noelmiller noelmiller requested a review from castrojo as a code owner March 28, 2024 15:55
p5
p5 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a nit, but otherwise LGTM

.github/workflows/build_iso.yml Show resolved Hide resolved
.github/workflows/build_iso.yml

env:
IMAGE_REGISTRY: ghcr.io/${{ github.repository_owner }}
workflow_call:
Copy link
Member

@p5 p5 Mar 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO controlling stuff like whether to push to R2 or GHA, and the channel (stable / testing) should be controlled in the calling workflow and not the reusable workflow, but this is a nit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better, but we currently manually call build_iso.yml on it's own for uploading ISOs, so it needs to operate independently of the other workflow.

KyleGospo
KyleGospo approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@KyleGospo KyleGospo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yo this is fire

@castrojo castrojo added this pull request to the merge queue Mar 28, 2024
@castrojo castrojo removed this pull request from the merge queue due to a manual request Mar 28, 2024
@castrojo castrojo added this pull request to the merge queue Mar 28, 2024
@castrojo castrojo removed this pull request from the merge queue due to a manual request Mar 28, 2024
@castrojo castrojo merged commit ce18074 into main Mar 28, 2024
64 checks passed
@castrojo castrojo deleted the testing branch March 28, 2024 18:46
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
@noelmiller
chore(ci): switch to upstream action and update workflows (ublue-os#1034
4ccd77b 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p5 p5 p5 approved these changes

@KyleGospo KyleGospo KyleGospo approved these changes

@bsherman bsherman Awaiting requested review from bsherman

@EyeCantCU EyeCantCU Awaiting requested review from EyeCantCU

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@noelmiller @abanna @KyleGospo @p5 @castrojo